-
-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip_file ignored when on the first docstring line #1840
Comments
|
FWIW, this is also ignored, new line with whitespace.
|
Here's an example of 5.10.0 ignoring directives (unless there's some intentional change I'm missing?): pydata/xarray#5949 |
Sorry for the noise! This should be fixed in https://github.com/PyCQA/isort/releases/tag/5.10.1, a contribution meant to avoid false flagging of non-comment isort: skip-files, was to narrow and has been reverted. In the meantime additional test cases will be added to catch this going forward. Thanks! ~Timothy |
This does not occur on version
5.9.3
.Since version
5.10.0
, the followingskip_file
directive is ignored:"""isort:skip_file"""
This is also ignored:
It needs to be on a new line:
The text was updated successfully, but these errors were encountered: