Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on 1-core machine #59

Closed
bmwiedemann opened this issue Sep 22, 2020 · 3 comments · Fixed by #65
Closed

Tests fail on 1-core machine #59

bmwiedemann opened this issue Sep 22, 2020 · 3 comments · Fixed by #65

Comments

@bmwiedemann
Copy link

While working on reproducible builds for openSUSE, I found that our python-sidpy package fails tests on a 1-core VM

 tests/proc/test_comp_utils.py::TestParallelCompute::test_invalid_func_type PASSED [ 78%]
 tests/proc/test_comp_utils.py::TestParallelCompute::test_respect_requested_cores Number of CPU free cores set to: 1 given that the CPU has 1 logical cores.
 2 cores requested.
 Clipped explicit request for CPU cores to: 1
 computational jobs per core = 30. For short computations, each core must have at least 20 jobs to warrant parallel computation.
 Computations are not lengthy.
 Rank 0 starting computing on 1 cores (requested 2 cores)
 Rank 0 computing serially ...

jmcarpenter2/swifter#102 solved a similar issue by skipping such tests when not enough cores were available.

to reproduce on openSUSE or Debian:

osc co openSUSE:Factory/python-sidpy && cd $_
osc build --vm-type=kvm -j1 --noservice standard

Maybe the issue can also be triggered via taskset 1 pytest-3.8

@ssomnath ssomnath linked a pull request Sep 25, 2020 that will close this issue
@ssomnath
Copy link
Member

@bmwiedemann - thank you for raising this issue. I have added appropriate safeguards for single core computations. We will be pushing out a new version with these fixes very soon.

May I ask why sidpy is being included in OpenSUSE?

@bmwiedemann
Copy link
Author

bmwiedemann commented Sep 28, 2020

May I ask why sidpy is being included in openSUSE?

I am not the maintainer, but think it is probably because of pyUSID

@ssomnath
Copy link
Member

I see. Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants