Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated reference to grunt #1721

Closed
jcass77 opened this issue Jul 18, 2018 · 3 comments
Closed

Remove outdated reference to grunt #1721

jcass77 opened this issue Jul 18, 2018 · 3 comments

Comments

@jcass77
Copy link
Contributor

jcass77 commented Jul 18, 2018

It looks like we might have missed a reference to grunt in the README as part of #1636: https://github.com/pydanny/cookiecutter-django/blame/95ee1f159ddaf481192e49235738785d1bfb8427/%7B%7Bcookiecutter.project_slug%7D%7D/README.rst#L91-L92

Not sure what the gulp equivalent should be though - is it as simple as running Mailhog for all deployments?

@sfdye
Copy link
Collaborator

sfdye commented Aug 29, 2018

Good find. I don't understand either why we need grunt here.

@webyneter Isn't this enough to use mailhog for non-docker setup?
https://cookiecutter-django.readthedocs.io/en/latest/developing-locally.html#mailhog

@browniebroke
Copy link
Member

Thanks @jcass77. You can see what Grunt was doing here. It's pretty simple, but not applicable for Docker.

In non-Docker + Gulp setup, we can implement a Gulp equivalent, by defining a task like this one, but starting Mailhog instead of Django, and add it to the default task dependencies. This way, Mailhog would start in the background.

@webyneter
Copy link
Collaborator

webyneter commented Aug 29, 2018

@sfdye yes, it should, I specifically reviewed the non-Docker Mailhog docs a few months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants