Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the dockerfile take care of installing mailhog? #475

Closed
ChrisPappalardo opened this issue Jan 21, 2016 · 3 comments
Closed

Shouldn't the dockerfile take care of installing mailhog? #475

ChrisPappalardo opened this issue Jan 21, 2016 · 3 comments

Comments

@ChrisPappalardo
Copy link
Contributor

In the previous versions of cookiecutter-django, maildump was installed in the docker dev container via the requirements file. I don't see anything that installs mailhog since the switch was made from maildump - or am I missing something?

@jayfk
Copy link
Collaborator

jayfk commented Jan 21, 2016

Yeah it should, but nobody has had the time to bring it to docker yet. There were/are some issues with grunt on docker that make this not so trivial.

@ChrisPappalardo
Copy link
Contributor Author

There's a mailhog image on Docker Hub. My solution for now is to implement mailhog as a separate docker container using the mailhog image, like so:

master...ChrisPappalardo:1.8.7_mailhog_container

I personally find this to be a cleaner and more "dockerish" implementation for development anyway, than having grunt run mailhog inside the django container. Maybe something to consider for master.

@jayfk
Copy link
Collaborator

jayfk commented May 25, 2016

We now have a mailhog container 👍

@jayfk jayfk closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants