Skip to content

Conversation

@alamb
Copy link

@alamb alamb commented Apr 7, 2025

Targets apache#15566

Here is a proposal to simplify the APIs.

In my opinion a typedef in Rust just adds cognitive overhead and makes the code harder to read. If we need a new type we should make a real struct with documentation, etc. A typedef just adds an extra layer of indirection.

I also think this change makes the code simpler

Both of these are subjective opinions

@alamb alamb force-pushed the alamb/remove_typedef branch from 84ea099 to a3d52d4 Compare April 7, 2025 20:42
@adriangb adriangb merged commit 5b3bccf into pydantic:filter-pushdown-apis Apr 7, 2025
27 checks passed
@adriangb
Copy link
Member

adriangb commented Apr 7, 2025

Don't fully agree but also think it's a super minor thing, let's go with your version!

@alamb alamb deleted the alamb/remove_typedef branch April 7, 2025 21:01
adriangb pushed a commit that referenced this pull request Apr 8, 2025
* Remove typedef ExecutionPlanFilterPushdownResult

* remove FileSourceFilterPushdownResult and DataSourceFilterPushdownResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants