Remove typedefs (e.g. ExecutionPlanFilterPushdownResult)
#24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets apache#15566
Here is a proposal to simplify the APIs.
In my opinion a typedef in Rust just adds cognitive overhead and makes the code harder to read. If we need a new type we should make a real struct with documentation, etc. A typedef just adds an extra layer of indirection.
I also think this change makes the code simpler
Both of these are subjective opinions