Fix schema for timedelta as number, instead of str #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 1771 1771
Branches 344 344
=====================================
Hits 1771 1771 |
|
great, thanks. will release in a couple of days. |
|
Awesome, thanks. 🎉 |
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
* adding multi host urls * linting and more test cases * tweak unicode_string logic to replace range * consume leading whitespace on multihost urls * yet more test cases * improve coverage * add vulnerabilties tests * remove "host_type" from url * fix unicode positioning with multihost urls * uprev * allow default_host, default_port, default_path * fix schema vs. scheme typo * empty hosts() if no host * tweaking url public methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Currently, the generated schema for
datetime.timedeltais asstring.But by default, Pydantic will convert it to a
floatwith the difference in seconds.(Bug created by me in the JSON Schema compatibility PR).
This PR fixes that and makes the schema for
timedeltabe anumberby default, which corresponds to the actual behavior.Related issue number
I didn't create one.
Performance Changes
pydantic cares about performance, if there's any risk performance changed on this PR,
please run
make benchmark-pydanticbefore and after the change:Checklist
HISTORY.rsthas been updated#<number>@whatever