Use getattr and default for qualname #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2023 09:06
Was suggested in python/cpython#102323 by @sobolevn. Fixes pydantic#5101 Superceedes pydantic#5102
|
I stumbled on the next problem while doing so, but a similiar problem was encountered by @larryhastings and others leading to python/cpython#91002 and python/cpython#74315, |
dmontagu
reviewed
Mar 1, 2023
dmontagu
reviewed
Mar 1, 2023
|
Seems reasonable to me with the caveats above. Defer to @samuelcolvin on whether there might be any other reasons to be concerned about merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was suggested in python/cpython#102323 by @sobolevn. Fixes #5101
Superceedes #5102