Fix generic typehint for pycharm #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2019 00:10
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 2800 2800
Branches 543 543
=====================================
Hits 2800 2800Continue to review full report at Codecov.
|
|
thanks. |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
* Fix generic typehint for pycharm * Add changes
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Modifies a type hint to prevent pycharm from raising warnings.
I believe this was caused by pycharm recently starting to incorporate the return type of
__class_getitem__into its type-checking logic.Related issue number
tiangolo/fastapi#653
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)