Skip to content

Initial start at improving import times for modules, using caching primarily #10009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 31, 2024
Merged

Initial start at improving import times for modules, using caching primarily #10009

merged 4 commits into from
Jul 31, 2024

Conversation

sydney-runkle
Copy link
Contributor

Potentially working on #9458

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 31, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 31, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6cc795
Status: ✅  Deploy successful!
Preview URL: https://1252271f.pydantic-docs.pages.dev
Branch Preview URL: https://import-improvements.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle added relnotes-performance Used for performance improvements. and removed relnotes-fix Used for bugfixes. labels Jul 31, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 31, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10009 will improve performances by 35.07%

Comparing import-improvements (f6cc795) with main (662fc9f)

Summary

⚡ 2 improvements
✅ 15 untouched benchmarks

Benchmarks breakdown

Benchmark main import-improvements Change
⚡ test_import_basemodel 113.9 µs 84.7 µs +34.53%
⚡ test_import_field 113 µs 83.7 µs +35.07%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

dmontagu
dmontagu reviewed Jul 31, 2024
View reviewed changes
dmontagu
dmontagu reviewed Jul 31, 2024
View reviewed changes
dmontagu
dmontagu reviewed Jul 31, 2024
View reviewed changes
sydney-runkle and others added 2 commits July 31, 2024 14:13
@sydney-runkle @dmontagu
Apply suggestions from code review
9ba1a7c 
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
@dmontagu
Improve import logic
f6cc795
@sydney-runkle sydney-runkle enabled auto-merge (squash) July 31, 2024 19:50
@sydney-runkle sydney-runkle merged commit 0501948 into main Jul 31, 2024
@sydney-runkle sydney-runkle deleted the import-improvements branch July 31, 2024 19:56
This was referenced Aug 1, 2024
Closed
Closed
Closed
@lmmx lmmx mentioned this pull request Sep 6, 2024
Closed
@sydney-runkle sydney-runkle mentioned this pull request Sep 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees
No one assigned
Labels
relnotes-performance Used for performance improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sydney-runkle @dmontagu