Fix Mapping and MutableMapping annotations to use mapping schema instead of dict schema
#10020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
1915046
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://06f8108c.pydantic-docs.pages.dev |
| Branch Preview URL: | https://fix-mapping.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10020 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
dmontagu
approved these changes
Aug 1, 2024
|
As in #10021 I'm a bit nervous that this could cause a breaking change for someone that might currently be using these types as field annotations, since it will change their behavior. But I guess it's probably worth the improvement. |
sydney-runkle
changed the title
Mapping and MutableMapping schemas to handle subclasses
|
Agreed, I think this is worth the improvement for now. I would categorize this as a bug fix honestly, given the incorrect placement of |
|
I think we can handle our subclass behavior in a separate PR. |
sydney-runkle
changed the title
Mapping and MutableMapping schemas to handle subclassesMapping and MutableMapping annotations to use mapping schema instead of dict schema
sydney-runkle
added
the
relnotes-change
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9549