Simplify internal generics logic - remove generator overhead #10059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
b7a8605
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4a8412b.pydantic-docs.pages.dev |
| Branch Preview URL: | https://generics-speedup.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10059 will not alter performanceComparing Summary
|
sydney-runkle
changed the title
sydney-runkle
changed the title
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
hramezani
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce generator overhead in recursive calls by using simple for loops - improves this
has_instance_in_typefunction by 20%, resulting in a 1% speedup globally.Continuing to chip away 1% by 1%.