Fix evaluation of __pydantic_extra__ annotation in specific circumstances
#10070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tances When a model is defined in a separate module and the core schema building was deferred (because `defer_build` was set or because it failed to evaluate an annotation), `GenerateSchema._model_schema` would use the wrong instance to evaluate the `__pydantic_extra__` annotation (so the wrong types namespace was used, resulting in an unhelpful `NameError`).
Viicos
changed the title
__pydantic_extra__ annotation in specific circums__pydantic_extra__ annotation in specific circumstances
Deploying pydantic-docs with
|
| Latest commit: |
a6c8fa4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0cdd1a5c.pydantic-docs.pages.dev |
| Branch Preview URL: | https://10069-extras-eval.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10070 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Aug 7, 2024
|
@sydney-runkle, https://github.com/pydantic/pydantic/pull/10070/files?diff=split&w=1 can help (hide whitespace enabled). |
|
Oh nice! I didn't know about the whitespace version. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model is defined in a separate module and the core schema building was deferred (because
defer_buildwas set or because it failed to evaluate an annotation),GenerateSchema._model_schemawould use the wrong instance to evaluate the__pydantic_extra__annotation (so the wrong types namespace was used, resulting in an unhelpfulNameError).Fixes #10069.
Change Summary
Related issue number
Checklist