Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Aug 7, 2024

This was introduced in #5490, but doesn't seem to be used.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

This was introduced in #5490, but doesn't seem
to be used.
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 7, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8629333
Status: ✅  Deploy successful!
Preview URL: https://88f2c045.pydantic-docs.pages.dev
Branch Preview URL: https://unused-get-schema-format.pydantic-docs.pages.dev

View logs

@Viicos Viicos requested a review from adriangb August 7, 2024 14:53
Copy link
Member

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 we can always add it back...

Copy link

codspeed-hq bot commented Aug 7, 2024

CodSpeed Performance Report

Merging #10075 will not alter performance

Comparing unused-get-schema-format (8629333) with main (87deca9)

Summary

✅ 17 untouched benchmarks

@Viicos
Copy link
Member Author

Viicos commented Aug 7, 2024

👍🏻 we can always add it back...

This seems to be the only code path allowing such a signature anyway :)

@Viicos Viicos enabled auto-merge (squash) August 7, 2024 14:58
@Viicos Viicos disabled auto-merge August 7, 2024 14:58
@Viicos Viicos enabled auto-merge (squash) August 7, 2024 14:58
@Viicos Viicos merged commit 441f6fe into main Aug 7, 2024
60 checks passed
@Viicos Viicos deleted the unused-get-schema-format branch August 7, 2024 15:02
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants