Improve pyright tests, refactor model decorators signatures
#10092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
4493ecc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25ce9029.pydantic-docs.pages.dev |
| Branch Preview URL: | https://10078-1.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10092 will not alter performanceComparing Summary
|
Update documentation regarding invalid decorators
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
sydney-runkle
suggested changes
Aug 10, 2024
There was a problem hiding this comment.
Truly fantastic work here. It's awesome to see how comfortable you are with the typing in this space of the codebase, and great to see such significant improvements.
I've left a few questions / requests.
Great work expanding the pyright test suite. This is a great way to track typing support issues / features going forward!
|
|
||
| return dec | ||
| return dec # pyright: ignore[reportReturnType] |
There was a problem hiding this comment.
Part of the reason I'm wondering if we lost some specificity here...
pydantic/functional_serializers.py
Outdated
| @@ -363,14 +392,14 @@ def serialize_model(self): | |||
| The decorator function. | |||
| """ | |||
|
|
|||
| def dec(f: Callable[..., Any]) -> _decorators.PydanticDescriptorProxy[Any]: | |||
| def dec(f: AnyModelPlainSerializer | AnyModelWrapSerializer) -> _decorators.PydanticDescriptorProxy[Any]: | |||
There was a problem hiding this comment.
👀
ModelSerializer: TypeAlias = 'AnyModelPlainSerializer | AnyModelWrapSerializer'
pydantic-hooky
bot
added
awaiting author revision
25 tasks
sydney-runkle
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10078
Checklist