Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Fix #8343

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 12, 2024
Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e56b3f5
Status: ✅  Deploy successful!
Preview URL: https://f2c2ebc0.pydantic-docs.pages.dev
Branch Preview URL: https://fix-ip-ser.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #10112 will not alter performance

Comparing fix-ip-ser (e56b3f5) with main (cb3ac5a)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _generate_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps ser_ip could be defined as a top level function to avoid being redefined every time. But not sure this has a huge impact on performance.

@sydney-runkle
Copy link
Contributor Author

Yeah, I think that's a valid point. We seem to use this pattern a lot with custom schemas re ser functions within a function. Will leave as is for now, but I'd certainly be interested in some refactoring of _generate_schema.py that makes general changes like that.

@sydney-runkle sydney-runkle merged commit 37536f6 into main Aug 13, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the fix-ip-ser branch August 13, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON serialization issue with ipaddress classes as alternative
2 participants