-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix ip schema serialization logic #10112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
e56b3f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2c2ebc0.pydantic-docs.pages.dev |
| Branch Preview URL: | https://fix-ip-ser.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10112 will not alter performanceComparing Summary
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps ser_ip could be defined as a top level function to avoid being redefined every time. But not sure this has a huge impact on performance.
|
Yeah, I think that's a valid point. We seem to use this pattern a lot with custom schemas re ser functions within a function. Will leave as is for now, but I'd certainly be interested in some refactoring of |
Fix #8343