Skip to content

Add dsn for Snowflake #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add dsn for Snowflake #10128

merged 3 commits into from
Aug 15, 2024

Conversation

aditkumar72
Copy link
Contributor

@aditkumar72 aditkumar72 commented Aug 14, 2024 •
edited by pydantic-hooky bot
Loading

Change Summary

Add dsn for Snowflake

Related issue number

fix #10079

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 14, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 14, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10128 will not alter performance

Comparing aditkumar72:snowflake-dsn (53ebbd3) with main (e9f30dc)

Summary

✅ 17 untouched benchmarks

@aditkumar72
Copy link
Contributor Author

@sydney-runkle please review

sydney-runkle
sydney-runkle approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'm digging into the pipeline failure now (it's not related to your code)

@sydney-runkle sydney-runkle enabled auto-merge (squash) August 14, 2024 18:24
@sydney-runkle sydney-runkle added relnotes-feature and removed relnotes-fix Used for bugfixes. labels Aug 14, 2024
@sydney-runkle sydney-runkle merged commit d08dccc into pydantic:main Aug 15, 2024
57 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sydney-runkle sydney-runkle

Labels
ready for review relnotes-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Snowflake DSN format
2 participants
@aditkumar72 @sydney-runkle