Fix core schema simplification when serialization schemas are involved in specific scenarios #10155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in specific scenarios
Deploying pydantic-docs with
|
| Latest commit: |
36c76df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30c993b1.pydantic-docs.pages.dev |
| Branch Preview URL: | https://9319.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10155 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sydney-runkle
approved these changes
Aug 16, 2024
| @@ -212,6 +212,7 @@ def _handle_other_schemas(self, schema: core_schema.CoreSchema, f: Walk) -> core | |||
| def _handle_ser_schemas(self, ser_schema: core_schema.SerSchema, f: Walk) -> core_schema.SerSchema: | |||
| schema: core_schema.CoreSchema | None = ser_schema.get('schema', None) | |||
| if schema is not None: | |||
| ser_schema = ser_schema.copy() | |||
There was a problem hiding this comment.
Suggested change
| ser_schema = ser_schema.copy() | |
| ser_schema = smart_deepcopy(ser_schema) |
Can we match the approach used in this PR? #9980
There was a problem hiding this comment.
I would rather stick with .copy here, as it is for the rest of the _WalkSchema implementation. deepcopy on a dict is slower and does not have any impact here, as .copy will create a shallow copy and this is enough (as we are only changing a top level key here, in this case the 'schema' key).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9319
After a lot of debugging in the core schema generation internals, I managed to find where the issue was coming from. I'm still unsure why using a
Sequenceinstead of alistleads to the original issue. My best guess is that is it purely a coincidence:Sequencecreates a different core schema, and probably it led to a really specific scenario where not having the serialization schema copied would result in a crash later on as theModel1definition wasn't saved retained (I suspect this issue where the serialization schema isn't copied already happened in other cases, but had no incident).Change Summary
Related issue number
Checklist