Improve runtime errors for string constraints like pattern for incompatible types
#10158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
e16d6ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aaae9df8.pydantic-docs.pages.dev |
| Branch Preview URL: | https://more-verbose-error-annotatio.pydantic-docs.pages.dev |
1 task
CodSpeed Performance ReportMerging #10158 will not alter performanceComparing Summary
|
sydney-runkle
added
relnotes-change
sydney-runkle
changed the title
pattern for incompatible types
adriangb
approved these changes
Aug 16, 2024
Comment on lines
+249
to
+254
| if 'type' in ve.errors()[0]['type']: | ||
| raise TypeError( | ||
| f"Unable to apply constraint '{constraint}' to supplied value {value} for schema of type '{schema_type}'" # noqa: B023 | ||
| ) | ||
| raise ve | ||
| return x |
There was a problem hiding this comment.
Maybe add an example here in a comment? It's not clear to me what the goal is just looking at hte code
There was a problem hiding this comment.
Done, thanks for the tip!
Coverage report
This PR does not seem to contain any modification to coverable code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10151
I suppose you could say this is contributing to #10036
Admittedly, this adds another custom wrap validator which is slower, but I think the behavior is better, and this is for a case that's already slow.