Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Aug 19, 2024

Change Summary

Fixes #10163

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 47d2b5b
Status: ✅  Deploy successful!
Preview URL: https://809441ce.pydantic-docs.pages.dev
Branch Preview URL: https://10163.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Aug 19, 2024

CodSpeed Performance Report

Merging #10172 will not alter performance

Comparing 10163 (47d2b5b) with main (823d51f)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sydney-runkle sydney-runkle merged commit 061e62c into main Aug 19, 2024
62 checks passed
@sydney-runkle sydney-runkle deleted the 10163 branch August 19, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema serialization of FloatEnums incorrectly assigns type 'numeric'
2 participants