Deprecate passing a dict to the Examples class
#10181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the necessary deprecation and user warnings Update tests
Deploying pydantic-docs with
|
| Latest commit: |
28dae6b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d85676f.pydantic-docs.pages.dev |
| Branch Preview URL: | https://json-schema-examples.pydantic-docs.pages.dev |
sydney-runkle
approved these changes
Aug 19, 2024
pydantic/json_schema.py
Outdated
Comment on lines
2453
to
2457
| warnings.warn( | ||
| 'Updating existing JSON Schema examples of type dict with examples of type list. ' | ||
| 'Only the existing examples values will be retained.', | ||
| UserWarning, | ||
| ) |
There was a problem hiding this comment.
Let's warn here (and on the next one) that dict is deprecated as well - I realize this will be raised in a separate warning, but I think it makes sense to reiterate in this one.
CodSpeed Performance ReportMerging #10181 will not alter performanceComparing Summary
|
5 tasks
sydney-runkle
added
relnotes-change
|
Great, go ahead and merge when you're ready 👍 |
Coverage report
This PR does not seem to contain any modification to coverable code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the necessary deprecation and user warnings
Update tests
Fixes #8732
Change Summary
Related issue number
Checklist