Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Aug 20, 2024

When a function is defined only with variable length positional arguments ((*args) -> ...), an empty prefixItems is added, which is invalid JSON Schema.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

…narios

When a function is defined only with variable length positional arguments
(`(*args) -> ...`), an empty `prefixItems` is added, which is invalid
JSON Schema.
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 20, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ca70a5
Status: ✅  Deploy successful!
Preview URL: https://c2ec2532.pydantic-docs.pages.dev
Branch Preview URL: https://p-arguments-schema.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #10188 will not alter performance

Comparing p-arguments-schema (7ca70a5) with main (dfe8415)

Summary

✅ 17 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@sydney-runkle sydney-runkle merged commit 5d99a65 into main Aug 20, 2024
62 checks passed
@sydney-runkle sydney-runkle deleted the p-arguments-schema branch August 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants