Skip to content

Raise helpful warning when self isn't returned from model validator #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2024
Merged

Raise helpful warning when self isn't returned from model validator #10255

merged 2 commits into from
Aug 28, 2024

Conversation

sydney-runkle
Copy link
Contributor

Fix #7252

@sydney-runkle sydney-runkle mentioned this pull request Aug 28, 2024
Closed
1 task
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Aug 28, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Aug 28, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: fd23252
Status: ✅  Deploy successful!
Preview URL: https://77271e9f.pydantic-docs.pages.dev
Branch Preview URL: https://warning-on-non-self-return.pydantic-docs.pages.dev

View logs

@sydney-runkle sydney-runkle added relnotes-change Used for changes to existing functionality which don't have a better categorization. and removed relnotes-fix Used for bugfixes. labels Aug 28, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10255 will not alter performance

Comparing warning-on-non-self-return (fd23252) with main (9f03db8)

Summary

✅ 30 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

Coverage report

This PR does not seem to contain any modification to coverable code.

sydney-runkle
sydney-runkle commented Aug 28, 2024
View reviewed changes
@sydney-runkle sydney-runkle enabled auto-merge (squash) August 28, 2024 19:12
@sydney-runkle sydney-runkle merged commit 8c1d235 into main Aug 28, 2024
60 checks passed
@sydney-runkle sydney-runkle deleted the warning-on-non-self-return branch August 28, 2024 19:20
@Viicos Viicos mentioned this pull request Aug 29, 2024
Merged
5 tasks
This was referenced Aug 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

@Viicos Viicos Awaiting requested review from Viicos

Assignees
No one assigned
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

model_validator return value is ignored on the top level model
2 participants
@sydney-runkle @davidhewitt