Fix parent namespace issue with model rebuilds #10257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10257 will not alter performanceComparing Summary
|
Deploying pydantic-docs with
|
| Latest commit: |
9bc5c88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5abc354.pydantic-docs.pages.dev |
| Branch Preview URL: | https://namespace-fix.pydantic-docs.pages.dev |
|
I've also opened #10260 to fix an issue that was causing memory blowup. |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, not going to move forward with the current solution, but wanted to sketch out what the problem was.
I think the best way forward here would be to further document what our internal namespace logic is doing, and separate out the different namespace fetching / caching logical paths.
Closes #10253