-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add in Hyperlint Base Style Guide + Spellcheck Configurations #10270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style_guide_test.md review details
Line Edit Problems/Proposals
Note: The following 3 comments are grouped by line.
Line 3
Existing text:
# This ia a test file
Issues:
- Style Guide - (Spelling-error) Did you really mean 'ia'?
Line 5
Existing text:
it will flag errors like on pydantic.
Issues:
- Style Guide - (Terms-error) Use 'Pydantic' instead of 'pydantic'.
Line 11
Existing text:
This is is an issue.
Issues:
- Style Guide - (Repetition-error) 'is' is repeated!
- Style Guide - (hyperlint.repeatedWords-error) 'is' is repeated, did you mean to repeat this word?
| @@ -0,0 +1,11 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will run the checks (but no recommendations) use it to iterate on the styles / dictionary. It doesn't need to be committed to the repo (but can be).
| @@ -0,0 +1,7 @@ | |||
| StylesPath = styles | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the base style guide check cconfiguration, no action needed here on your part - this won't change much or often.
| @@ -0,0 +1,12 @@ | |||
| validator | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is your custom dictionary: Read more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll expand on this when I do some docs updates tomorrow.
| @@ -0,0 +1,6 @@ | |||
| extends: repetition | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a custom rule, lots of possibilities here but best to start simple. Read more here
As you make changes, you'll get more comments like this. If the style guide test file is present on a pull request, then it will post a comment like that on every update. |
CodSpeed Performance ReportMerging #10270 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - left some comments attempting to fix linting issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style_guide_test.md review details
Line Edit Problems/Proposals
Note: The following 3 comments are grouped by line.
Line 3
Existing text:
# This ia a test file
Issues:
- Style Guide - (Spelling-error) Did you really mean 'ia'?
Line 5
Existing text:
it will flag errors like on pydantic.
Issues:
- Style Guide - (Terms-error) Use 'Pydantic' instead of 'pydantic'.
Line 11
Existing text:
This is is an issue.
Issues:
- Style Guide - (hyperlint.repeatedWords-error) 'is' is repeated, did you mean to repeat this word?
- Style Guide - (Repetition-error) 'is' is repeated!
|
cc @Viicos, this could be a great way to enforce Pydantic and |
…ic#10270) Co-authored-by: bllchmbrs <bill@hyperlint.com> Co-authored-by: Sydney Runkle <54324534+sydney-runkle@users.noreply.github.com>
Change Summary
This adds in the base Hyperlint configurations and shows where to add files to effectively configure your style guide and rules.
Related issue number
NA
Checklist
Please review @sydney-runkle