Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 3, 2024

Change Summary

Fixes #10284.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 3, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 3, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 414f43f
Status: ✅  Deploy successful!
Preview URL: https://66a0096a.pydantic-docs.pages.dev
Branch Preview URL: https://10284-dc-complete.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Sep 3, 2024

CodSpeed Performance Report

Merging #10291 will not alter performance

Comparing 10284-dc-complete (414f43f) with main (0a78494)

Summary

✅ 45 untouched benchmarks

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, good work here. Let's wait on merging anything until after the v2.9 release - I can do that later this week.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  dataclasses.py
  pydantic/_internal
  _dataclasses.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle sydney-runkle merged commit 5c24abb into main Sep 4, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the 10284-dc-complete branch September 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__pydantic_complete__ is not updated when rebuilding dataclass
2 participants