Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 6, 2024

Change Summary

Fixes #10345

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 6, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 924d54c
Status: ✅  Deploy successful!
Preview URL: https://192a5a64.pydantic-docs.pages.dev
Branch Preview URL: https://10345.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the 10345 branch 2 times, most recently from 438128c to 3e11754 Compare September 7, 2024 13:32
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #10347 will not alter performance

Comparing 10345 (924d54c) with main (e060425)

Summary

✅ 49 untouched benchmarks

@Viicos Viicos marked this pull request as ready for review September 7, 2024 13:48
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _model_construction.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@sydney-runkle sydney-runkle merged commit c19e3bd into main Sep 7, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the 10345 branch September 7, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to evaluate type annotation 'ClassVar[str]' error when creating BaseModel with ClassVar using from __future__ import annotations
2 participants