Fix PydanticUserError on empty model_config with annotations
#10412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a `PydanticUserError` from being raised when `model_config` has
type annotations (`model_config: ConfigDict`), but is also empty.
For example, this previously raised a `PydanticUserError`:
class Model(BaseModel):
model_config: ConfigDict = {}
Fixes pydantic#10411
CodSpeed Performance ReportMerging #10412 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Viicos
approved these changes
Sep 15, 2024
|
Thanks for the bug report and fix @cdwilson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Prevents a
PydanticUserErrorfrom being raised whenmodel_confighas type annotations (model_config: ConfigDict), but is also empty.For example, this previously raised a
PydanticUserError:Related issue number
Fixes #10411
Checklist