Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 16, 2024

Change Summary

Fixes #9619
Requires pydantic/pydantic-core#1451

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 16, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 068bdc9
Status: ✅  Deploy successful!
Preview URL: https://7313594d.pydantic-docs.pages.dev
Branch Preview URL: https://kwargs-td.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Sep 16, 2024

CodSpeed Performance Report

Merging #10416 will not alter performance

Comparing kwargs-td (068bdc9) with main (9b69920)

Summary

✅ 38 untouched benchmarks

@Viicos Viicos marked this pull request as ready for review September 17, 2024 13:56
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's add documentation to both the concepts and api sections of the docs.

Re API section - you can add this to the standard library types area.

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author labels Sep 17, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 outstanding issue(s) found.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Thanks for adding a test for the override as well.

@sydney-runkle sydney-runkle enabled auto-merge (squash) September 20, 2024 17:26
@sydney-runkle sydney-runkle added relnotes-feature and removed awaiting author revision awaiting changes from the PR author relnotes-fix Used for bugfixes. labels Sep 20, 2024
@sydney-runkle
Copy link
Contributor

cc @Viicos, I don't think this was addressed:

LGTM - let's add documentation to both the concepts and api sections of the docs.

Going ahead and merging this now, but could you add docs for this next week?

@sydney-runkle sydney-runkle merged commit e301d4a into main Sep 20, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the kwargs-td branch September 20, 2024 17:52
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typing.Unpack support: Unpack typed dict for keyword argument typing
2 participants