Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Sep 19, 2024

Change Summary

Fixes #10443.
I'm not too happy with the solution, feels a bit weird to have to worry about this inside count_refs, but couldn't find a better fix.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 19, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f29c68
Status: ✅  Deploy successful!
Preview URL: https://1af52f31.pydantic-docs.pages.dev
Branch Preview URL: https://10443.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #10444 will improve performances by 13.81%

Comparing 10443 (6f29c68) with main (01daafa)

Summary

⚡ 1 improvements
✅ 36 untouched benchmarks

Benchmarks breakdown

Benchmark main 10443 Change
test_field_validators_serializers 2.8 ms 2.5 ms +13.81%

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _core_utils.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems alright to me for now, thanks for adding the inline comment.

@sydney-runkle sydney-runkle merged commit 61818e2 into main Sep 19, 2024
62 checks passed
@sydney-runkle sydney-runkle deleted the 10443 branch September 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema generation error when serialization schema holds a reference
2 participants