Skip to content

Conversation

kschwab
Copy link
Contributor

@kschwab kschwab commented Sep 25, 2024

Change Summary

Fixes representation of builtin function types evaluated in display_as_type function.

Related issue number

Fixes #10228

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Sep 25, 2024
Copy link

codspeed-hq bot commented Sep 25, 2024

CodSpeed Performance Report

Merging #10479 will not alter performance

Comparing kschwab:builtin-function-repr (afd8e55) with main (43ed0d3)

Summary

✅ 38 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic/_internal
  _repr.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix :)

@sydney-runkle sydney-runkle merged commit c9190ee into pydantic:main Sep 25, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Issue with Internal Representation of Function Types
2 participants