Support compiled patterns in protected_namespaces
#10522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
35804ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d4c38ffd.pydantic-docs.pages.dev |
| Branch Preview URL: | https://support-re-for-protected-ns.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10522 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
Viicos
reviewed
Oct 1, 2024
Viicos
reviewed
Oct 1, 2024
dmontagu
reviewed
Oct 1, 2024
| if ann_name.startswith(protected_namespace): | ||
| ns_violation: bool = False | ||
| if isinstance(protected_namespace, Pattern): | ||
| ns_violation = protected_namespace.match(ann_name) is not None |
There was a problem hiding this comment.
Is match better than fullmatch here? I think match might be equally capable and more practical (don't need to include .* on the end to serve as a prefix match I guess), just want to make sure you've thought about it and decided to go with match.
There was a problem hiding this comment.
Good question - I think match is more practical, as you can use special characters (ex: ^<pattern>$) to basically ensure fullmatch behavior, whereas fullmatch does that by default and thus offers less customizability 👍
dmontagu
reviewed
Oct 1, 2024
dmontagu
approved these changes
Oct 1, 2024
Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Merge branch 'support-re-for-protected-ns' of https://github.com/pydantic/pydantic into support-re-for-protected-ns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigDict.protected_namespacesnow supports matching on compiled patterns.Whereas we used to only support prefix check for
strtype protected namespaces, this now expands the customizability of a protected namespace significantly.