Skip to content

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Sep 30, 2024

Making progress on #10299
Requires pydantic/pydantic-core#1469

Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e2c059
Status: ✅  Deploy successful!
Preview URL: https://32c7bc58.pydantic-docs.pages.dev
Branch Preview URL: https://invalid-schema.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Oct 11, 2024

CodSpeed Performance Report

Merging #10523 will not alter performance

Comparing invalid-schema (2e2c059) with main (ba50d94)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@sydney-runkle
Copy link
Contributor Author

A bit stumped here. @davidhewitt, maybe we could chat on Monday. Do you think it makes sense to have InvalidSchema as a member of the CoreSchema type alias? It doesn't have a serialization key, which is throwing off the type checker in cases where we apply schema['serialization'] to a CoreSchema instance...

Going to pause dev here until we've made a decision on that front.

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 15, 2024 15:31
@sydney-runkle sydney-runkle merged commit 51cf3cb into main Oct 15, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the invalid-schema branch October 15, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants