-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Allow schema_extra to be a callable #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1054 +/- ##
======================================
Coverage 100% 100%
======================================
Files 20 20
Lines 3349 3352 +3
Branches 661 662 +1
======================================
+ Hits 3349 3352 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM.
Humm, thanks but I think it get's complicated if we start providing functions for these cases within pydantic, there are hundreds of different changes that people might want. I think best to leave things like this up to package users. |
|
Thanks! Believe the comments have been addressed.
Agreed. Sounds good. |
|
great, thank you. |
|
Thanks to you! Cheers. |
* fixes for Windows development * Allow Config.schema_extra to be a callable
Change Summary
Allow
Config.schema_extrato be a callable so that the generated schema can be post-processed.Also includes some fixes to the dev scripts for Windows development (I'm on Windows with cmder). Those can be moved to another PR if needed.
Related issue number
fix #889, fix #1051
Checklist
changes/1054-selimb.mdfile added describing change(see changes/README.md for details)