Support constraint application for Base64Etc types
#10584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
8b4f35d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e998034b.pydantic-docs.pages.dev |
| Branch Preview URL: | https://bytes-fix.pydantic-docs.pages.dev |
5 tasks
CodSpeed Performance ReportMerging #10584 will not alter performanceComparing Summary
|
sydney-runkle
commented
Oct 9, 2024
| @@ -2580,7 +2593,7 @@ def decode_str(self, data: bytes, _: core_schema.ValidationInfo) -> str: | |||
| Returns: | |||
| The decoded data. | |||
| """ | |||
| return data.decode() | |||
| return self.encoder.decode(data.encode()).decode() | |||
There was a problem hiding this comment.
So that I understand the intent here - we validate a str, then encode -> bytes, decode with our encoder, then decode back to a str? 🤮
There was a problem hiding this comment.
yeah, since the encoder operates on bytes I think you need to do this if you want to apply it to strings
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
dmontagu
approved these changes
Oct 11, 2024
|
I think this is the right behavior, but if we have any issues with this type in v2.10, this would be the PR to revisit. Seems pretty low stakes, though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #10500
Fixes #9251
Had to decouple (though, I view this as a sort of simplification) the
EncodedBytesandEncodedStrdataclases. The API here feels a bit confusing- having theencoderseparate from these types that define the pydantic methods seems overly complex.Additionally, the
EncodedStrtype (unless I'm misunderstanding) does quite a large amount of encoding and decoding for both validation and serialization...The main fix here is using
handler(source)as the schema for the validator functions so that any constraints applied to the original type are respected.