Skip to content

Conversation

kc0506
Copy link
Contributor

@kc0506 kc0506 commented Oct 12, 2024

Change Summary

Related issue number

fix #10569

edit: fix #10610.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 12, 2024
Copy link
Contributor

github-actions bot commented Oct 12, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks @kc0506!

Copy link

codspeed-hq bot commented Oct 13, 2024

CodSpeed Performance Report

Merging #10610 will not alter performance

Comparing kc0506:fix-validate-call-annotated (a2f6c55) with main (28662ff)

Summary

✅ 38 untouched benchmarks

@sydney-runkle sydney-runkle enabled auto-merge (squash) October 13, 2024 11:18
@sydney-runkle sydney-runkle merged commit 2b2dffc into pydantic:main Oct 13, 2024
58 checks passed
@kc0506 kc0506 deleted the fix-validate-call-annotated branch October 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate_call appears to ignore discriminated Unions
2 participants