Tweak type alias logics #10643
Merged
Tweak type alias logics #10643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10643 will not alter performanceComparing Summary
|
|
@Viicos, could you take a look at this one? You've had your head in this space recently... |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Viicos
reviewed
Oct 17, 2024
Comment on lines
+1041
to
+1042
| if isinstance(origin, TypeAliasType): | ||
| return self._type_alias_type_schema(obj) |
There was a problem hiding this comment.
I think without a special reason (e.g. dataclass above), these matching clauses should better be put together to make things clearer. Looks like when origin is of type TypeAliasType, from_property is always None (at least in the current tests), so moving it does not have any actual effect.
sydney-runkle
added
the
awaiting author revision
Viicos
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Put type alias logic after
from_property.Related issue number
Checklist