Skip to content

Use overloads for Field and PrivateAttr functions #10651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 18, 2024
Merged

Use overloads for Field and PrivateAttr functions #10651

merged 4 commits into from
Oct 18, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 17, 2024

This typechecks the default and default_factory arguments, and removes the need for a custom mypy plugin hook.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@Viicos
Use overloads for Field and PrivateAttr functions
1d47dcc 
This typechecks the `default` and `default_factory` arguments,
and removes the need for a custom mypy plugin hook.
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 17, 2024
@Viicos Viicos mentioned this pull request Oct 17, 2024
Merged
5 tasks
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 60e97ce
Status: ✅  Deploy successful!
Preview URL: https://3e80c252.pydantic-docs.pages.dev
Branch Preview URL: https://fields-func-overloads.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10651 will not alter performance

Comparing fields-func-overloads (60e97ce) with main (0359a21)

Summary

✅ 44 untouched benchmarks

sydney-runkle
sydney-runkle reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, much cleaner!

@sydney-runkle
Copy link
Contributor

Pending happy mypy, I'm good with this 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  fields.py
  pydantic/_internal
  _model_construction.py
Project Total  

This report was generated by python-coverage-comment-action

@sydney-runkle
Copy link
Contributor

Update: disabled mypy tests bc they're being flaky. We will investigate before closing #10623

@Viicos Viicos merged commit 06a04b5 into main Oct 18, 2024
62 checks passed
@Viicos Viicos deleted the fields-func-overloads branch October 18, 2024 17:57
@Viicos Viicos mentioned this pull request Jan 8, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sydney-runkle