Skip to content

Conversation

mschoettle
Copy link
Contributor

@mschoettle mschoettle commented Oct 21, 2024

Change Summary

The typechecking job fails due to an unused type: ignore[...]. See: https://github.com/pydantic/pydantic/actions/runs/11446111308/job/31844612840?pr=10676

This PR removes this comment.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #10677 will not alter performance

Comparing mschoettle:fix-typechecking-ignore (c365a7e) with main (6681c00)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@mschoettle
Copy link
Contributor Author

please review

@Viicos
Copy link
Member

Viicos commented Oct 21, 2024

Ok so turns out the test is still flaky. It was enabled today in #10671. Could you please instead re-add the same condition here? I'll debug in a separate PR.

@mschoettle mschoettle force-pushed the fix-typechecking-ignore branch from 30301c1 to b4bdeb9 Compare October 21, 2024 20:06
@mschoettle mschoettle changed the title Remove unused mypy type ignore Mark mypy integration tests as flaky again in CI Oct 21, 2024
@mschoettle
Copy link
Contributor Author

@Viicos Okay, that explains why it suddenly appeared again. Changed as requested.

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Viicos Viicos enabled auto-merge (squash) October 21, 2024 20:09
@Viicos Viicos merged commit e7cfe9e into pydantic:main Oct 21, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants