Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 23, 2024

Change Summary

Closes #9402

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Oct 23, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b7b9a11
Status: ✅  Deploy successful!
Preview URL: https://94db0bd4.pydantic-docs.pages.dev
Branch Preview URL: https://literal-enum-js-schema-2.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Oct 23, 2024

CodSpeed Performance Report

Merging #10692 will not alter performance

Comparing literal-enum-js-schema-2 (b7b9a11) with main (bdb04ac)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, clean fix.

@sydney-runkle sydney-runkle merged commit dc1ee23 into main Oct 23, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the literal-enum-js-schema-2 branch October 23, 2024 19:16
frankie567 added a commit to polarsource/polar that referenced this pull request Dec 20, 2024
Pydantic 2.10 removes the `enum` field from JSON schema, which breaks our internal SDK generator. See: pydantic/pydantic#10692
frankie567 added a commit to polarsource/polar that referenced this pull request Dec 20, 2024
Pydantic 2.10 removes the `enum` field from JSON schema, which breaks our internal SDK generator. See: pydantic/pydantic#10692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema for Literal differs between version 2.6 and 2.7
2 participants