Skip to content

Conversation

UriyaHarpeness
Copy link
Contributor

@UriyaHarpeness UriyaHarpeness commented Oct 30, 2024

Change Summary

Fix broken note tag under https://docs.pydantic.dev/dev/api/functional_validators/#pydantic.functional_validators.PlainValidator.
image

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @sydney-runkle

Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #10740 will not alter performance

Comparing UriyaHarpeness:feature/fix-broken-note-tag (b0601ae) with main (6b92e9d)

Summary

✅ 44 untouched benchmarks

@UriyaHarpeness
Copy link
Contributor Author

please review

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sydney-runkle sydney-runkle merged commit 21563d7 into pydantic:main Oct 30, 2024
53 checks passed
@UriyaHarpeness UriyaHarpeness deleted the feature/fix-broken-note-tag branch October 30, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants