Skip to content

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 6, 2024

Change Summary

Fixes #10772

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 6, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ee960d
Status: ✅  Deploy successful!
Preview URL: https://c3228600.pydantic-docs.pages.dev
Branch Preview URL: https://cached-property-set.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the cached-property-set branch from b27dec8 to 3ee960d Compare November 6, 2024 11:24
Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #10774 will not alter performance

Comparing cached-property-set (3ee960d) with main (fba836a)

Summary

✅ 44 untouched benchmarks

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  pydantic
  main.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Viicos!

@sydney-runkle sydney-runkle merged commit 3d00314 into main Nov 6, 2024
54 checks passed
@sydney-runkle sydney-runkle deleted the cached-property-set branch November 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cached_property cannot be assigned by recommended way
2 participants