Fix schema for fields with nested None as default #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As None is typically used for the default value, it is not usually encoded on its own into schemas. There was an issue, where using None not as the top-level value, but rather inside other objects (e.g. [None]) will throw a Traceback.
lutostag
force-pushed
the
schema-nested-none
branch
from
21af0f2 to
0f49bf0
Compare
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
======================================
Coverage 100% 100%
======================================
Files 20 20
Lines 3365 3367 +2
Branches 663 664 +1
======================================
+ Hits 3365 3367 +2
Continue to review full report at Codecov.
|
dmontagu
approved these changes
Dec 8, 2019
|
awesome, thank you very much. |
andreshndz
pushed a commit
to cuenca-mx/pydantic
that referenced
this pull request
Jan 17, 2020
fix pydantic#1087 As None is typically used for the default value, it is not usually encoded on its own into schemas. There was an issue, where using None not as the top-level value, but rather inside other objects (e.g. [None]) will throw a Traceback.
alexdrydew
pushed a commit
to alexdrydew/pydantic
that referenced
this pull request
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As None is typically used for the default value, it is not usually
encoded on its own into schemas. Issue #1087 , where using None
not as the top-level value, but rather inside other objects (e.g.
[None]) will throw a Traceback.
Original issue found downstream at fastapi/fastapi#776
Change Summary
Handle the None case in
pydantic.schema.encode_defaultRelated issue number
#1087
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)
Not sure if any documentation is needed here. If you are looking for anything different or this doesnt work for some case, please let me know, and I will be more than happy to follow any suggestions!
Thanks!