Relax check for validated data in default factory utils #10909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying pydantic-docs with
|
| Latest commit: |
dcfe613
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e3f818a.pydantic-docs.pages.dev |
| Branch Preview URL: | https://validated-data-fix.pydantic-docs.pages.dev |
dmontagu
approved these changes
Nov 20, 2024
CodSpeed Performance ReportMerging #10909 will not alter performanceComparing Summary
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
This was referenced Nov 20, 2024
36 tasks
sydney-runkle
changed the title
Viicos
reviewed
Nov 21, 2024
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
…ntic into validated-data-fix
Viicos
approved these changes
Nov 21, 2024
brentyi
added a commit
to brentyi/tyro
that referenced
this pull request
Nov 21, 2024
sydney-runkle
added a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
brentyi
added a commit
to brentyi/tyro
that referenced
this pull request
Nov 23, 2024
…oved error messages (#204) * Improve mismatched type for StrEnum * Overhaul subcommand matching * Additional subcommand matching tests * Min 3.11 for StrEnum tests * fix test ignore * Test nits * typeguard compatibility * Add minimum typeguard version * fix typeguard errors * typeguard refactor, more subcommand matching tests * Add 3.13 to CI (fixes #206) * Add pydantic version exclude, waiting for patch Related: pydantic/pydantic#10912, pydantic/pydantic#10909 * Improve type warnings + errors * Generic subcommand example, docs updates * Remove unused * `build` => `pytest`, closes #206 * mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #10678 (comment)
cc @Viicos, breaking for this case: #10905 (comment)
I think moving inside here makes sense. Though, I understood your original point in the comment 👍
Fixes #10912