Skip to content

Conversation

sydney-runkle
Copy link
Contributor

Sort of reverting #10576

Fixes #10917

@sydney-runkle sydney-runkle requested a review from Viicos November 21, 2024 15:56
@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 21, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 21, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e56f547
Status: ✅  Deploy successful!
Preview URL: https://2e46f788.pydantic-docs.pages.dev
Branch Preview URL: https://db-fix.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #10928 will not alter performance

Comparing db-fix (e56f547) with main (9915abf)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert the documentation changes I did in the original PR?

@Viicos Viicos changed the title Fix dataclass config inheritance Use the parent configuration during schema generation for stdlib dataclasses Nov 21, 2024
sydney-runkle and others added 4 commits November 21, 2024 11:19
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
@sydney-runkle
Copy link
Contributor Author

Should we revert the documentation changes I did in the original PR?

Yes, good call. Done. I've applied your other suggestions as well 👍

@sydney-runkle sydney-runkle enabled auto-merge (squash) November 21, 2024 16:27
@sydney-runkle sydney-runkle merged commit 3cb6852 into main Nov 21, 2024
53 checks passed
@sydney-runkle sydney-runkle deleted the db-fix branch November 21, 2024 16:34
sydney-runkle added a commit that referenced this pull request Nov 22, 2024
…classes (#10928)

Co-authored-by: Victorien <65306057+Viicos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.10: dataclass config issues (arbitrary_types_allowed, aliases, etc)
2 participants