Do not evaluate annotations for private fields #10962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Viicos
force-pushed
the
private-fields-eval
branch
from
fe38cc5 to
2861b87
Compare
Deploying pydantic-docs with
|
| Latest commit: |
213b274
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e420a41e.pydantic-docs.pages.dev |
| Branch Preview URL: | https://private-fields-eval.pydantic-docs.pages.dev |
CodSpeed Performance ReportMerging #10962 will not alter performanceComparing Summary
|
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Viicos
force-pushed
the
private-fields-eval
branch
2 times, most recently
from
2d35039 to
76460e2
Compare
|
Nice! |
Viicos
force-pushed
the
private-fields-eval
branch
from
76460e2 to
8446583
Compare
The `get_cls_type_hints` function is now split up, by defining a new `get_model_type_hints` function that is lenient. `get_cls_type_hints` is made non-lenient because it is used for typed dictionaries and named tuples, where we want to eagerly raise the `NameError`s that can occur during evaluation. While this may introduce some code duplication, this gives more flexibility in the future. For instance, we know from the namespace management refactor that typed dicts behaves quite differently from normal classes when it comes to using the `__annotations__` attribute (collected from bases by cpython, automatically converted to `ForwardRef` instances, etc). So we might define another separate `get_typed_dict_type_hints` function in the future.
Viicos
force-pushed
the
private-fields-eval
branch
from
8446583 to
213b274
Compare
potiuk
approved these changes
Nov 24, 2024
5 tasks
36 tasks
sydney-runkle
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Looks good, thanks @Viicos.
We might be able to reuse some shared logic between these functions in a future refactor, but the fix here is pretty simple, so I think we should get this across the line now 👍
sydney-runkle
pushed a commit
that referenced
this pull request
Nov 26, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Nov 26, 2024
The Pydantic 2.10.0/2.10.1 workaround implemented in apache#44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2.
ferruzzi
pushed a commit
to apache/airflow
that referenced
this pull request
Nov 26, 2024
The Pydantic 2.10.0/2.10.1 workaround implemented in #44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2.
ArshiaZr
pushed a commit
to ArshiaZr/airflow
that referenced
this pull request
Nov 27, 2024
The Pydantic 2.10.0/2.10.1 workaround implemented in apache#44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2.
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
The Pydantic 2.10.0/2.10.1 workaround implemented in apache#44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
The Pydantic 2.10.0/2.10.1 workaround implemented in apache#44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2.
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 27, 2025
The Pydantic 2.10.0/2.10.1 workaround implemented in #44317 is not needed any more as it has been fixed in Pydantic 2.10.2 in the pydantic/pydantic#10962 This PR removes the workaround and bumps min Pydantic version to 2.10.2. GitOrigin-RevId: b134ed089b74021858ded34dbc021ef053427650
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so fixes #10958 and gtalarico/pyairtable#411. We don't need to evaluate annotation for private fields because we will not make use of the type hint in any way.
The
get_cls_type_hintsfunction is now split up, by defining a newget_model_type_hintsfunction that is lenient.get_cls_type_hintsis made non-lenient because it is used for typed dictionaries and named tuples, where we want to eagerly raise theNameErrors that can occur during evaluation.While this may introduce some code duplication, this gives more flexibility in the future. For instance, we know from the namespace management refactor that typed dicts behaves quite differently from normal classes when it comes to using the
__annotations__attribute (collected from bases by cpython, automatically converted toForwardRefinstances, etc). So we might define another separateget_typed_dict_type_hintsfunction in the future.Change Summary
Related issue number
Checklist