Skip to content

Do not resolve the JSON Schema reference for dict core schema keys #10989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

Do not resolve the JSON Schema reference for dict core schema keys #10989

merged 1 commit into from
Dec 2, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Nov 27, 2024

The referenced schema might not be available yet.

Fixes #10960.

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Nov 27, 2024
@Viicos Viicos mentioned this pull request Nov 27, 2024
Closed
36 tasks
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 27, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 75ddc34
Status: ✅  Deploy successful!
Preview URL: https://ca106d21.pydantic-docs.pages.dev
Branch Preview URL: https://js-dict-keys-ref.pydantic-docs.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 27, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #10989 will not alter performance

Comparing js-dict-keys-ref (75ddc34) with main (6f31f8f)

Summary

✅ 46 untouched benchmarks

@Viicos
Do not resolve the JSON Schema reference for dict core schema keys
75ddc34 
The referenced schema might not be available yet.
@github-actions GitHub Actions
Copy link
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  pydantic
  json_schema.py
Project Total  

This report was generated by python-coverage-comment-action

@Viicos Viicos mentioned this pull request Nov 28, 2024
Closed
1 task
sydney-runkle
sydney-runkle approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix!

@sydney-runkle sydney-runkle merged commit dd95071 into main Dec 2, 2024
54 checks passed
@sydney-runkle sydney-runkle deleted the js-dict-keys-ref branch December 2, 2024 15:41
sydney-runkle pushed a commit that referenced this pull request Dec 3, 2024
@Viicos @sydney-runkle
Do not resolve the JSON Schema reference for dict core schema keys (#…
cb962c1 
…10989)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem generating OpenAPI schema for models with an enum as the key of a dict
2 participants
@Viicos @sydney-runkle