Skip to content

Conversation

davidhewitt
Copy link
Contributor

Change Summary

To pull in fixes for 2.10.

Related issue number

#10910

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 18, 2024
Copy link

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a94da79
Status: ✅  Deploy successful!
Preview URL: https://ae0aafcb.pydantic-docs.pages.dev
Branch Preview URL: https://dh-core-2-27-2.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #11138 will improve performances by 10.81%

Comparing dh/core-2.27.2 (a94da79) with main (a915c7c)

Summary

⚡ 18 improvements
✅ 28 untouched benchmarks

Benchmarks breakdown

Benchmark main dh/core-2.27.2 Change
test_efficiency_with_highly_nested_examples 774 µs 716.2 µs +8.07%
test_complex_model_serialization 62.3 µs 59.2 µs +5.35%
test_list_of_models_serialization 62.7 µs 59.3 µs +5.74%
test_model_json_serialization 66 µs 60.9 µs +8.32%
test_nested_model_serialization 44.6 µs 41.6 µs +7.13%
test_simple_model_serialization 35 µs 32.3 µs +8.13%
test_complex_model_validation[__init__] 58.7 µs 54.9 µs +6.92%
test_complex_model_validation[model_validate] 59.5 µs 54.7 µs +8.76%
test_list_of_models_validation[__init__] 101.4 µs 93.9 µs +7.98%
test_list_of_models_validation[model_validate] 100.1 µs 92 µs +8.82%
test_nested_model_validation[__init__] 61.1 µs 57.1 µs +6.95%
test_nested_model_validation[model_validate] 58.6 µs 54.2 µs +8.09%
test_simple_model_validation[__init__] 42.8 µs 40.6 µs +5.48%
test_simple_model_validation[model_validate] 43.6 µs 40.7 µs +7.31%
test_north_star_dump_json 30.8 ms 28.5 ms +8.15%
test_north_star_dump_python 17.3 ms 16 ms +7.96%
test_north_star_validate_python 48.2 ms 45.8 ms +5.23%
test_north_star_validate_python_strict 30.2 ms 27.3 ms +10.81%

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thanks!

@sydney-runkle sydney-runkle merged commit d8b610c into main Dec 18, 2024
55 checks passed
@sydney-runkle sydney-runkle deleted the dh/core-2.27.2 branch December 18, 2024 14:12
@sydney-runkle sydney-runkle added relnotes-packaging Used for dependency changes. backport-2.10 and removed relnotes-fix Used for bugfixes. labels Dec 18, 2024
sydney-runkle pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-packaging Used for dependency changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants