Skip to content

Fix conditional expressions syntax for third-party tests #11162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix conditional expressions syntax for third-party tests #11162

merged 2 commits into from
Dec 20, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Dec 20, 2024 •
edited
Loading

Change Summary

As per https://github.com/orgs/community/discussions/25641#discussioncomment-3248571.

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 20, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 20, 2024 •
edited
Loading

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 172b777
Status: ✅  Deploy successful!
Preview URL: https://4070d45b.pydantic-docs.pages.dev
Branch Preview URL: https://debug-3rd-party.pydantic-docs.pages.dev

View logs

@Viicos Viicos force-pushed the debug-3rd-party branch 3 times, most recently from d414cff to 7959c79 Compare December 20, 2024 17:38
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 20, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #11162 will not alter performance

Comparing debug-3rd-party (172b777) with main (debffa5)

Summary

✅ 46 untouched benchmarks

@github-actions GitHub Actions
Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

@Viicos Viicos force-pushed the debug-3rd-party branch 2 times, most recently from dda24a0 to b3d7cea Compare December 20, 2024 18:05
@Viicos Viicos changed the title Debug 3rd party tests Fix conditional expressions syntax for third-party tests Dec 20, 2024
@Viicos Viicos mentioned this pull request Dec 20, 2024
Closed
@Viicos Viicos marked this pull request as ready for review December 20, 2024 18:26
sydney-runkle
sydney-runkle approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lgtm

Viicos
Viicos commented Dec 20, 2024
View reviewed changes
@Viicos Viicos enabled auto-merge (squash) December 20, 2024 18:54
@Viicos Viicos merged commit 7b9561f into main Dec 20, 2024
56 checks passed
@Viicos Viicos deleted the debug-3rd-party branch December 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sydney-runkle