Skip to content

Conversation

mdaffad
Copy link
Contributor

@mdaffad mdaffad commented Dec 24, 2024

Change Summary

Integrate beanie tests on third party test workflow, part of third party tests on #11160.
Workflow result - https://github.com/mdaffad/pydantic/actions/runs/12477146497

Related issue number

#11160

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 24, 2024
Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #11177 will not alter performance

Comparing mdaffad:ci/third-party-beanie (7749fbf) with main (daa0732)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

github-actions bot commented Dec 24, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks great

@mdaffad mdaffad requested a review from Viicos December 25, 2024 04:12
@sydney-runkle sydney-runkle added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 27, 2024
@sydney-runkle sydney-runkle removed the relnotes-fix Used for bugfixes. label Dec 27, 2024
@sydney-runkle sydney-runkle mentioned this pull request Dec 27, 2024
16 tasks
@sydney-runkle
Copy link
Contributor

LGTM, let's wait for @Viicos' approval before we merge :)

@Viicos Viicos changed the title ci: Third party test for beanie Add third-party tests for BeanieODM Dec 28, 2024
Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Viicos Viicos merged commit 3294b9f into pydantic:main Dec 28, 2024
73 checks passed
@mdaffad mdaffad deleted the ci/third-party-beanie branch December 28, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants