Skip to content

Conversation

sydney-runkle
Copy link
Contributor

@sydney-runkle sydney-runkle commented Dec 27, 2024

Follow up to #11171

Update the issue creation to include case where openapi tests fail, and update branch pointer.

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Dec 27, 2024
@sydney-runkle sydney-runkle changed the title CI: open issue for openai third party test failures CI: open issue for openapi third party test failures Dec 27, 2024
@sydney-runkle sydney-runkle requested a review from Viicos December 27, 2024 16:11
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c5ec7e
Status: ✅  Deploy successful!
Preview URL: https://72ad6d94.pydantic-docs.pages.dev
Branch Preview URL: https://openai-check.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #11182 will not alter performance

Comparing openai-check (9c5ec7e) with main (fac2bfd)

Summary

✅ 46 untouched benchmarks

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@Viicos Viicos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you also update the checked out repo? My PR was merged since then.

@sydney-runkle sydney-runkle added the third-party-tests Add this label on a PR to trigger 3rd party tests label Dec 27, 2024
@sydney-runkle
Copy link
Contributor Author

sydney-runkle commented Dec 27, 2024

Manually triggered the workflow here to confirm things are working: https://github.com/pydantic/pydantic/actions/runs/12518334387, as I added third-party-tests after pushing.

In a future PR we could make this workflow trigger on a label change as well, though that's low priority.

@sydney-runkle sydney-runkle enabled auto-merge (squash) December 27, 2024 16:50
@Viicos Viicos changed the title CI: open issue for openapi third party test failures Include openapi-python-client check in issue creation for third-party failures, use main branch Dec 27, 2024
@sydney-runkle sydney-runkle merged commit daa0732 into main Dec 27, 2024
73 checks passed
@sydney-runkle sydney-runkle deleted the openai-check branch December 27, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes. third-party-tests Add this label on a PR to trigger 3rd party tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants